New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the light theme #17

Open
Cassolotl opened this Issue Nov 15, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@Cassolotl

Cassolotl commented Nov 15, 2017

This menu's text is too light (Android):

chr1

Can the search box's magnifying glass/cross be darker?

chr2

Text is too light on toot pages:

chr3

Boost button is too light on hover, while other buttons are not.

chr4

Text in emoji picker is too light:

chr5

The DM envelope symbol is too light:

screen_shot_2017-11-16_at_15_07_29

When there are new posts to see the Home icon vanishes, which is a bit too subtle, I think?

screen shot 2017-11-17 at 09 40 09

Some too-light bits, highlighted with green, on profiles (the one in the example is mine):

screen_shot_2017-11-19_at_22_18_58

The report text box text is too light:

screen_shot_2017-12-02_at_17_43_33

Hashtags in search dropdown could be darker:

screen shot 2017-12-02 at 21 09 52


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@chr-1x

This comment has been minimized.

Show comment
Hide comment
@chr-1x

chr-1x Nov 19, 2017

Collaborator

Notes for myself

  • toot button pressed state should be light pink while not pressable
  • admin panel stuff
  • invert logo colors in settings
  • modal dialogs
Collaborator

chr-1x commented Nov 19, 2017

Notes for myself

  • toot button pressed state should be light pink while not pressable
  • admin panel stuff
  • invert logo colors in settings
  • modal dialogs
@chr-1x

This comment has been minimized.

Show comment
Hide comment
@chr-1x

chr-1x Dec 19, 2017

Collaborator

As of the 2.1 update to the light theme I think most of these should be resolved! Feel free to comment / reopen the issue if you find anything new~

Collaborator

chr-1x commented Dec 19, 2017

As of the 2.1 update to the light theme I think most of these should be resolved! Feel free to comment / reopen the issue if you find anything new~

@chr-1x chr-1x closed this Dec 19, 2017

@Cassolotl

This comment has been minimized.

Show comment
Hide comment
@Cassolotl

Cassolotl Dec 19, 2017

The boost button is still behaving differently to the other buttons on hover, and this page has a text-is-too-light thing: https://cybre.space/settings/migration

screen shot 2017-12-19 at 10 46 27

On profiles with migration notices, the text on the migration notice isn't visible:

screen shot 2017-12-19 at 17 56 58

It is all looking so good, I love the border on the toot box and stuff like that! :)

Cassolotl commented Dec 19, 2017

The boost button is still behaving differently to the other buttons on hover, and this page has a text-is-too-light thing: https://cybre.space/settings/migration

screen shot 2017-12-19 at 10 46 27

On profiles with migration notices, the text on the migration notice isn't visible:

screen shot 2017-12-19 at 17 56 58

It is all looking so good, I love the border on the toot box and stuff like that! :)

@chr-1x chr-1x reopened this Dec 19, 2017

@chr-1x

This comment has been minimized.

Show comment
Hide comment
Collaborator

chr-1x commented Dec 20, 2017

@andy-morris

This comment has been minimized.

Show comment
Hide comment
@andy-morris

andy-morris Jun 8, 2018

The text in the emoji search is almost invisible for me:

image

andy-morris commented Jun 8, 2018

The text in the emoji search is almost invisible for me:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment