- normalizing default relation nullability for BelongsTo, ManyToMany

cycle · Sep 5, 2019 · 40dcfb5 · 40dcfb5
1 parent 3d7c12e
commit 40dcfb5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Relation/BelongsTo.php b/src/Relation/BelongsTo.php
@@ -33,7 +33,7 @@ final class BelongsTo extends RelationSchema implements InversableInterface
         Relation::LOAD               => Relation::LOAD_PROMISE,
 
         // nullable by default
-        Relation::NULLABLE           => true,
+        Relation::NULLABLE           => false,
 
         // link to parent entity primary key by default
         Relation::INNER_KEY          => '{relation}_{outerKey}',

diff --git a/src/Relation/HasMany.php b/src/Relation/HasMany.php
@@ -32,12 +32,12 @@ final class HasMany extends RelationSchema implements InversableInterface
         // do not pre-load relation by default
         Relation::LOAD               => Relation::LOAD_PROMISE,
 
-        // custom where condition
-        Relation::WHERE              => [],
-
         // not nullable by default
         Relation::NULLABLE           => false,
 
+        // custom where condition
+        Relation::WHERE              => [],
+
         // link to parent entity primary key by default
         Relation::INNER_KEY          => '{source:primaryKey}',
 

diff --git a/src/Relation/ManyToMany.php b/src/Relation/ManyToMany.php
@@ -33,7 +33,7 @@ final class ManyToMany extends RelationSchema implements InversableInterface
         Relation::LOAD               => Relation::LOAD_PROMISE,
 
         // nullable by default
-        Relation::NULLABLE           => true,
+        Relation::NULLABLE           => false,
 
         // custom where condition
         Relation::WHERE              => [],