Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file upload example and address issue #294 with solution. #868

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@JuniperChicago
Copy link

commented Dec 22, 2018

  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit

JuniperChicago added some commits Dec 7, 2018

@staltz

This comment has been minimized.

Copy link
Member

commented Dec 22, 2018

Hi @JuniperChicago, thanks for the initiative. Is this a work in progress PR? There are a couple things to do before merging:

  • Squash all commits into one and use pnpm run commit
  • Remove commented code
  • Reformat code using prettier, like in the rest of the codebase
  • Remove CSS styles that make this example differ from other examples
  • etc (I'll review more, also Jan might review)
@JuniperChicago

This comment has been minimized.

Copy link
Author

commented Dec 27, 2018

@staltz, I was doing work on a file uploader and encountered gaps in documentation and examples on successfully attaching files to http post operations. I thought a representative example might be useful. So this example contains:

  • accept dragged and dropped files
  • files can be added by using
  • a list showing all files selected
  • files can be uploaded to server also included in example
  • use @cycle/http request and response streams
  • use of @cycle/state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.