Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: most-run to support @most/core #881

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@janat08
Copy link

commented Mar 30, 2019

feat(most-run): uses @most/create that isn't officially supported. Is backwards compatible.

Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously
@Most and mostjs with it's backwards compatibility. Untested since it relies on run to support
unadapt, a method replace xs.fromPromise in run to support @Most. Doesn't add tests to run, making
sure that drivers actually get proper sources. There're some warning in most@ as to how custom
stream creators should be made, which I just assume create package respects as the warning's meaning
was beyond me.

BREAKING CHANGE:
none

ISSUES CLOSED: #845

  • [*] There exists an issue discussing the need for this PR
  • [*] I added new tests for the issue I fixed or built, kinda. run isn't tested with unadapt
  • [*] I used pnpm run commit instead of git commit
most-run to support @most/core
feat(most-run): uses @most/create that isn't officially supported. Is backwards compatible.

Uses @most/create that isn't officially supported, I imagine in terms of it handling simultaneously
@Most and mostjs with it's backwards compatibility. Untested since it relies  on run to support
unadapt, a method replace xs.fromPromise in run to support @Most. Doesn't add tests to run, making
sure that drivers actually get proper sources. There're some warning in most@ as to how custom
stream creators should be made, which I just assume create package respects as the warning's meaning
was beyond me.

BREAKING CHANGE:
none

ISSUES CLOSED: #845
@janat08

This comment has been minimized.

Copy link
Author

commented Mar 30, 2019

It hypothetically may not actually stop running streams provided to xs.fromObservable.

@janat08 janat08 changed the title most-run to support @most/core WIP: most-run to support @most/core Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.