Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window driver #883

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@janat08
Copy link

commented Apr 12, 2019

  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit

###--------------------------------------------------------###
feat(dom): window driver for events

Window driver following examples set in dom driver for domsource and etc. Has no documentation as it
was metioned that this might go into repository of its own rather than official one at first.

BREAKING CHANGE:
none

ISSUES CLOSED: #568
###--------------------------------------------------------###

@janat08 janat08 force-pushed the janat08:window branch from 01fede9 to 655625c Apr 12, 2019

window driver
###--------------------------------------------------------###
feat(dom): window driver for events

Window driver following examples set in dom driver for domsource and etc. Has no documentation as it
was metioned that this might go into repository of its own rather than official one at first.

BREAKING CHANGE:
none

ISSUES CLOSED: #568
###--------------------------------------------------------###

@janat08 janat08 force-pushed the janat08:window branch from 2a0b652 to 2e1c859 Apr 12, 2019

@janat08 janat08 changed the title WIP: window driver window driver Apr 12, 2019

@janat08

This comment has been minimized.

Copy link
Author

commented Apr 12, 2019

For some reason there're CI errors on lint, whereas on local it errors on a bunch of packages. I had karma working week before, and now it's not anymore with Error: You need to include some adapter that implements __karma__.start method. From what I remember those tests indeed pass. I couldn't get special handler for resize events to work with strict types.

@janat08

This comment has been minimized.

Copy link
Author

commented Apr 12, 2019

Do you want this a separate package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.