-
Notifications
You must be signed in to change notification settings - Fork 14
Respect react event handler #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
staltz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, I think this change makes sense. I have one request, written inline.
Note, ideally the addition of prettier would be a separate PR (or at least separate commit), it's not good for codebase maintenance (e.g. using git blame) to have unrelated changes all together in one commit, but I don't mind merging it like this right now. So, no action needed from you, I'm just informing what's preferable for the next times.
9068d46 to
c201239
Compare
|
Made PR with formatting #14 and then tried to rebase this PR, not sure if I did right with this PR. |
|
The |
|
I suppose you're done and this is ready to merge? @whitecolor |
|
I believe yes, if not count a mess with commits. |
|
Thanks! |
|
Release 2.9.0 |
@cycle/reactcurrenlty replaces react handler on the element with its own event handler, this probably should be changed and the existing handler should be respected and executed.The case for this: sometimes react expects that the event handler to return a value (for example if to pass the event or something like this). So this PR checks if handler exists and executes it after cycle event handler.
Also added prettier config. If ok with this PR, probably need to check and set new formatting of other files as well.
@staltz