Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give MapMarker and MapMarker2 descriptive names #98

Closed
reinierl opened this issue Oct 31, 2021 · 1 comment
Closed

Give MapMarker and MapMarker2 descriptive names #98

reinierl opened this issue Oct 31, 2021 · 1 comment
Labels
average priority code-quality Places where we have to improve the way functionality is coded good first issue Good for newcomers help wanted Extra attention is needed

Comments

@reinierl
Copy link
Collaborator

At the moment wetwo Vue components named "MapMarker":

MapMarker
MapMarker2

These have to be given better names that describe the differences between them. Also we should check if in fact they can be combined into one component that can be parameterised for the desired behaviour or looks.
@reinierl reinierl added average priority code-quality Places where we have to improve the way functionality is coded good first issue Good for newcomers help wanted Extra attention is needed labels Oct 31, 2021
bidsinga added a commit that referenced this issue Nov 5, 2021
@bidsinga
issue #98 fixed
e0272f6
@bidsinga
Copy link
Collaborator

bidsinga commented Nov 5, 2021

MapMarker is moved to componentns/Country folder and renamed to CountryPOIs
MapMarker2 is renamed to POIList

@bidsinga bidsinga closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
average priority code-quality Places where we have to improve the way functionality is coded good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reinierl @bidsinga