Skip to content

Avoid crash when no app can open an external link #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid crash when no app can open an external link #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libraries/cyclestreets-fragments/src/main/java/net/cyclestreets/WebPageFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package net.cyclestreets

import android.annotation.SuppressLint
import android.content.ActivityNotFoundException
import android.content.Context
import android.content.Intent
import android.net.Uri
Expand All @@ -12,6 +13,7 @@ import android.view.ViewGroup
import android.webkit.WebResourceRequest
import android.webkit.WebView
import android.webkit.WebViewClient
import android.widget.Toast

import net.cyclestreets.fragments.R

Expand Down Expand Up @@ -57,7 +59,11 @@ open class WebPageFragment : Fragment {

// Otherwise, give the default behavior (open in browser)
val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url))
context.startActivity(intent)
try {
context.startActivity(intent)
} catch (e: ActivityNotFoundException) {
Toast.makeText(context, R.string.no_app_to_open_link, Toast.LENGTH_SHORT).show()
}
return true
}
}
Expand Down
2 changes: 2 additions & 0 deletions libraries/cyclestreets-fragments/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,6 @@
<string name="storedroutes_detail_default">Details</string>
<string name="storedroutes_detail_format">%1$s route, %2$s</string>

<string name="no_app_to_open_link">No app found to open this link</string>

</resources>