New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include photos from CycleStreets by reference #213
Comments
I like this idea - I see this as a 'Photos from CycleStreets nearby' panel, basically giving a mini photomap that users could then click on a bubble in and add this as a reference. |
As a first start, it would be useful to have CycleStreets photos on the main map for the issue, in the same way that collisions can be switched on. So would have a button "Show photos from CycleStreets" which would add the same data layer shown at using this API: |
A draft of this should be on staging, if your happy with that @mvl22 then we can close this (and finish Tranche 3) |
The integration is working fine (great!), but there is some very odd interaction between the two checkboxes now - do you not see the same thing? They don't seem to act independently, with inconsistent on/off behaviour. Collisions no longer actually seem to show either. |
Once that aspect is done we then need to get the second part in place, which is just as important:
In practice that will become the thing that is most used. I envisage the same browsing map, but perhaps with a button in the popup that selects it, and enables a caption to be added, as per the Google Street View integration. |
Also, should Cyclescape pull all the data and store it or should it only really store the id and get the rest from Cyclestreets? For example. if a user includes a photo I think that photo shouldn't change even if the Cyclestreets user updates the photo or location. |
We need to bite the bullet on this at some point. I think we should just start a second row for now. In my view the recent changes for the Leader stuff will need this anyway.
Yes.
Correct - selecting a photo should pull in the data and clone it into the Cyclescape database. There should be no further Photomap API call. Obviously selecting a photo should pre-fill the caption, to save the user having to do that. |
All seems fine, except two things:
|
This all works fine now and is fine to deploy - thanks for the fix. They correctly work as two independent checkbox controls. |
We already have a home for geographically located photos with other valuable metadata which could be incorporated into a thread by reference (e.g. with an additional tab in the kinds of item which could be added to a thread). This would avoid duplication, but let us see the data in line rather than have to jump to it, and also recognises the data may already exists, so no need to re-upload it.
The text was updated successfully, but these errors were encountered: