New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include photos from CycleStreets by reference #213

Closed
davidearl opened this Issue Jun 12, 2013 · 10 comments

Comments

Projects
None yet
3 participants
@davidearl

davidearl commented Jun 12, 2013

We already have a home for geographically located photos with other valuable metadata which could be incorporated into a thread by reference (e.g. with an additional tab in the kinds of item which could be added to a thread). This would avoid duplication, but let us see the data in line rather than have to jump to it, and also recognises the data may already exists, so no need to re-upload it.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Jun 12, 2013

Member

I like this idea - I see this as a 'Photos from CycleStreets nearby' panel, basically giving a mini photomap that users could then click on a bubble in and add this as a reference.

Member

mvl22 commented Jun 12, 2013

I like this idea - I see this as a 'Photos from CycleStreets nearby' panel, basically giving a mini photomap that users could then click on a bubble in and add this as a reference.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Dec 22, 2015

Member

As a first start, it would be useful to have CycleStreets photos on the main map for the issue, in the same way that collisions can be switched on.

So
http://camcycle.cyclescape.org/issues/127-chisholm-trail

would have a button "Show photos from CycleStreets"

which would add the same data layer shown at
http://www.cyclestreets.net/photomap/

using this API:
http://www.cyclestreets.net/api/v2/photomap.locations/

Member

mvl22 commented Dec 22, 2015

As a first start, it would be useful to have CycleStreets photos on the main map for the issue, in the same way that collisions can be switched on.

So
http://camcycle.cyclescape.org/issues/127-chisholm-trail

would have a button "Show photos from CycleStreets"

which would add the same data layer shown at
http://www.cyclestreets.net/photomap/

using this API:
http://www.cyclestreets.net/api/v2/photomap.locations/

@nikolai-b

This comment has been minimized.

Show comment
Hide comment
@nikolai-b

nikolai-b Sep 17, 2016

Contributor

A draft of this should be on staging, if your happy with that @mvl22 then we can close this (and finish Tranche 3)

Contributor

nikolai-b commented Sep 17, 2016

A draft of this should be on staging, if your happy with that @mvl22 then we can close this (and finish Tranche 3)

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Sep 17, 2016

Member

The integration is working fine (great!), but there is some very odd interaction between the two checkboxes now - do you not see the same thing? They don't seem to act independently, with inconsistent on/off behaviour.

Collisions no longer actually seem to show either.

Member

mvl22 commented Sep 17, 2016

The integration is working fine (great!), but there is some very odd interaction between the two checkboxes now - do you not see the same thing? They don't seem to act independently, with inconsistent on/off behaviour.

Collisions no longer actually seem to show either.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Sep 17, 2016

Member

Once that aspect is done we then need to get the second part in place, which is just as important:

additional tab in the kinds of item which could be added to a thread

In practice that will become the thing that is most used.

I envisage the same browsing map, but perhaps with a button in the popup that selects it, and enables a caption to be added, as per the Google Street View integration.

Member

mvl22 commented Sep 17, 2016

Once that aspect is done we then need to get the second part in place, which is just as important:

additional tab in the kinds of item which could be added to a thread

In practice that will become the thing that is most used.

I envisage the same browsing map, but perhaps with a button in the popup that selects it, and enables a caption to be added, as per the Google Street View integration.

@nikolai-b

This comment has been minimized.

Show comment
Hide comment
@nikolai-b

nikolai-b Sep 18, 2016

Contributor

So a user selects the Cyclescape Photo (maybe next to the Photo option), sees the map, selects a photo, has the option to add a caption?

E.g like this bad mock up (should be Cyclestreet Photo not street view selected)...
bad mock up

We can't add another reply type without thinking about it as the list starts to be too long. It could be a picture sub-type?

Contributor

nikolai-b commented Sep 18, 2016

So a user selects the Cyclescape Photo (maybe next to the Photo option), sees the map, selects a photo, has the option to add a caption?

E.g like this bad mock up (should be Cyclestreet Photo not street view selected)...
bad mock up

We can't add another reply type without thinking about it as the list starts to be too long. It could be a picture sub-type?

@nikolai-b

This comment has been minimized.

Show comment
Hide comment
@nikolai-b

nikolai-b Sep 18, 2016

Contributor

Also, should Cyclescape pull all the data and store it or should it only really store the id and get the rest from Cyclestreets? For example. if a user includes a photo I think that photo shouldn't change even if the Cyclestreets user updates the photo or location.

Contributor

nikolai-b commented Sep 18, 2016

Also, should Cyclescape pull all the data and store it or should it only really store the id and get the rest from Cyclestreets? For example. if a user includes a photo I think that photo shouldn't change even if the Cyclestreets user updates the photo or location.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Sep 18, 2016

Member

We can't add another reply type without thinking about it as the list starts to be too long.

We need to bite the bullet on this at some point. I think we should just start a second row for now. In my view the recent changes for the Leader stuff will need this anyway.

So a user selects the Cyclescape Photo (maybe next to the Photo option), sees the map, selects a photo, has the option to add a caption?

Yes.

Also, should Cyclescape pull all the data and store it or should it only really store the id and get the rest from Cyclestreets? For example. if a user includes a photo I think that photo shouldn't change even if the Cyclestreets user updates the photo or location.

Correct - selecting a photo should pull in the data and clone it into the Cyclescape database. There should be no further Photomap API call.

Obviously selecting a photo should pre-fill the caption, to save the user having to do that.

Member

mvl22 commented Sep 18, 2016

We can't add another reply type without thinking about it as the list starts to be too long.

We need to bite the bullet on this at some point. I think we should just start a second row for now. In my view the recent changes for the Leader stuff will need this anyway.

So a user selects the Cyclescape Photo (maybe next to the Photo option), sees the map, selects a photo, has the option to add a caption?

Yes.

Also, should Cyclescape pull all the data and store it or should it only really store the id and get the rest from Cyclestreets? For example. if a user includes a photo I think that photo shouldn't change even if the Cyclestreets user updates the photo or location.

Correct - selecting a photo should pull in the data and clone it into the Cyclescape database. There should be no further Photomap API call.

Obviously selecting a photo should pre-fill the caption, to save the user having to do that.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Oct 9, 2016

Member

All seems fine, except two things:

  1. Once a message has been created, clicking on the image to show the full resolution image doesn't work - the image src is presumably wrong.

  2. /overview lists this as "Cyclestreets Photo Message Html" which sounds very geeky.

Member

mvl22 commented Oct 9, 2016

All seems fine, except two things:

  1. Once a message has been created, clicking on the image to show the full resolution image doesn't work - the image src is presumably wrong.

  2. /overview lists this as "Cyclestreets Photo Message Html" which sounds very geeky.

@mvl22

This comment has been minimized.

Show comment
Hide comment
@mvl22

mvl22 Oct 9, 2016

Member

some very odd interaction between the two checkboxes now
Collisions no longer actually seem to show either.

This all works fine now and is fine to deploy - thanks for the fix. They correctly work as two independent checkbox controls.

Member

mvl22 commented Oct 9, 2016

some very odd interaction between the two checkboxes now
Collisions no longer actually seem to show either.

This all works fine now and is fine to deploy - thanks for the fix. They correctly work as two independent checkbox controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment