Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set "My Location" #845

Closed
mattturner86 opened this issue Apr 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mattturner86
Copy link

commented Apr 6, 2019

I've just deleted all of my locations, intending to add a new one after, but the location webpages are failing to load correctly.
Both the "My Locations" page and "Edit Location" page are returning Javascript errors.
These pages were loading fine before I deleted my locations.

username: mattturner86@gmail.com
Browser: Chrome (73.0.3683.86) and Edge (42.17134.1.0)

I've included a screenshot of both pages as well as the Javascript console error for each (which seem to be the same)

https://www.cyclescape.org/settings/locations
image
image

https://www.cyclescape.org/user/locations/new
image
image

Thanks!

@nikolai-b nikolai-b closed this in c21432c Apr 7, 2019

@nikolai-b

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

Thanks @mattturner86 , we should have been treating empty features (locations) as invalid but a while ago we allowed changed to accepting a collection of features, instead of just one feature, and the test if a collection is empty is a bit different and was overlooked.

I've deployed the new code and ran

DELETE FROM user_locations WHERE ST_IsEmpty(location) = 'T';

to delete any existing empty locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.