Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map style switcher should have cookie memory #924

Closed
mvl22 opened this issue Feb 8, 2020 · 5 comments
Closed

Map style switcher should have cookie memory #924

mvl22 opened this issue Feb 8, 2020 · 5 comments

Comments

@mvl22
Copy link
Member

@mvl22 mvl22 commented Feb 8, 2020

On maps like /issues#map-pane, the map style switcher (OpenCycleMap/OS/OSM) works nicely, but the choice is not remembered next time the page is navigated to.

We should set a style cookie, which applies to any map view, that is changed when the switcher is changed.

OpenCycleMap can remain as the default.

@nikolai-b

This comment has been minimized.

Copy link
Contributor

@nikolai-b nikolai-b commented Feb 8, 2020

@mvl22

This comment has been minimized.

Copy link
Member Author

@mvl22 mvl22 commented Feb 8, 2020

It shouldn't need the server to know. The standard thing here is just a client-side cookie. Not sure why local storage would be used instead, but sure.

@nikolai-b

This comment has been minimized.

Copy link
Contributor

@nikolai-b nikolai-b commented Feb 8, 2020

@mvl22

This comment has been minimized.

Copy link
Member Author

@mvl22 mvl22 commented Feb 8, 2020

Make it simple: global - one flag which takes effect everywhere that a map is shown. Changing the map on one screen somewhere results in other pages in the following navigation picking up that change.

@nikolai-b nikolai-b closed this in 40884c4 Mar 6, 2020
@mvl22

This comment has been minimized.

Copy link
Member Author

@mvl22 mvl22 commented Mar 8, 2020

Working nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.