Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag map #927

Closed
nikolai-b opened this issue Feb 26, 2020 · 4 comments
Closed

Add tag map #927

nikolai-b opened this issue Feb 26, 2020 · 4 comments

Comments

@nikolai-b
Copy link
Contributor

@nikolai-b nikolai-b commented Feb 26, 2020

On https://www.cyclescape.org/tags/cyclepath make the page full screen and stick in a map of all the tags, add a popup with a link to the issue. From #923

nikolai-b added a commit that referenced this issue Feb 26, 2020
Re #927
nikolai-b added a commit that referenced this issue Feb 27, 2020
Re #927
@nikolai-b

This comment has been minimized.

Copy link
Contributor Author

@nikolai-b nikolai-b commented Feb 29, 2020

I've made the map fixed (sticky) so it moves with the page. Is that what you wanted?

Screenshot_2020-02-29 Cyclescape(2)

@mvl22

This comment has been minimized.

Copy link
Member

@mvl22 mvl22 commented Feb 29, 2020

I've made the map fixed (sticky) so it moves with the page.

Can you clarify sorry?

I would allow it to be slippy so that people can browse beyond the group's area for those tags, out of curiosity.

@mvl22

This comment has been minimized.

Copy link
Member

@mvl22 mvl22 commented Feb 29, 2020

Oh, as in CSS position fixed. Err, yes, probably that will be fine.

I'll check on staging when it lands there.

@nikolai-b nikolai-b closed this in b7fd90c Mar 11, 2020
@mvl22

This comment has been minimized.

Copy link
Member

@mvl22 mvl22 commented Mar 11, 2020

I see this is working. The layout is acceptable, and obviously will be handled properly with the new design.

Could you make the overlay colour (currently light blue) on the full map be the same as the individual maps (currently dark gray) - see the difference:

Screen Shot 2020-03-11 at 22 53 52

@mvl22 mvl22 reopened this Mar 11, 2020
@nikolai-b nikolai-b closed this in 8dfa045 Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.