CompositionTests.lineage tries to decay empty compositions #761

Open
scopatz opened this Issue Mar 5, 2014 · 10 comments

Projects

None yet

3 participants

@scopatz
Member
scopatz commented Mar 5, 2014

This seems weird and stems from the fact that c is never initialized, only declared. I don't think that we should support this. Decay should actually throw an error for empty compositions, I think.

@scopatz scopatz added the Testing label Mar 5, 2014
@rwcarlsen
Member

We can change it to use non-empty compositions. It doesn't really matter because the functionality being tested in that test doesn't have anything to do with a decay calculation. It is just testing that a compositions decay dt history is tracked properly so as to avoid repeating decays that have already been calculated.

@rwcarlsen
Member

Or we could even just throw an exception if anybody tries to create an empty composition - since it is sort of undefined.

@scopatz
Member
scopatz commented Mar 7, 2014

Well people might want to create an empty composition and then build it up. Should they just be using CompMap in this case, though?

@rwcarlsen
Member

Yep - that is for CompMap. Composition object is immutable.

On Fri, Mar 7, 2014 at 4:13 PM, Anthony Scopatz notifications@github.comwrote:

Well people might want to create an empty composition and then build it
up. Should they just be using CompMap in this case, though?

Reply to this email directly or view it on GitHubhttps://github.com/cyclus/cyclus/issues/761#issuecomment-37073652
.

@scopatz
Member
scopatz commented May 17, 2014

Leaving this be for 1.0

@scopatz
Member
scopatz commented Aug 26, 2014

moving to 1.2

@scopatz scopatz added this to the v1.2 milestone Aug 26, 2014
@scopatz
Member
scopatz commented Nov 24, 2014

Moved to v1.3

@scopatz scopatz modified the milestone: v1.3, v1.2 Nov 24, 2014
@gidden
Member
gidden commented Apr 24, 2015

@rwcarlsen / @scopatz, can you give an update on this issue?

@rwcarlsen
Member

the short is that nothing will happen for 1.3. Also, the level of bugness of this is arguable - there are many other higher priority things IMO.

@gidden
Member
gidden commented Apr 25, 2015

to 1.4

@gidden gidden modified the milestone: v1.4, v1.3 Apr 25, 2015
@gidden gidden added the PR-Low label Apr 25, 2015
@rwcarlsen rwcarlsen modified the milestone: v1.4, v1.5 Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment