New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix xonsh links #14
fix xonsh links #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks like there is one lingering reference to xonsh
docs/conf.py
Outdated
@@ -211,7 +211,7 @@ | |||
# Grouping the document tree into LaTeX files. List of tuples | |||
# (source start file, target name, title, author, documentclass [howto/manual]). | |||
latex_documents = [ | |||
('index', 'xonsh.tex', u'xonsh documentation', | |||
('index', 'xonsh.tex', u'rickshaw documentation', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the 2nd entry still be xonsh.tex
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! fixed!
LGTM - thanks @scopatz |
Does this automatically get deployed? Or do I need to (figure out how to) do that? |
It seems that doctr is set up on this repo, so it should have already been deployed. |
cool - this is my first look at |
Yes, I think that is what is happening. I think the idea is that the docs are built for every PR (as a test) and then when the PR is merged, the docs are built again and actually deployed (pushed to the github pages repo). |
But it appears that the docs are deployed each time a PR is tested... or is doctr wise enough to avoid that? |
I think it depends on how it is setup, and it may not be set up correctly here. @asmeurer @gforsyth and @CJ-Wright might have a better answer to that question. |
I think doctr knows if it is building on the master branch and doesn't push unless it is on the master branch, unless you have some special settings. |
doctr only pushes from master unless |
And yes, in a PR, doctr runs all the steps of the deploy sans the push in every build to ensure that they would work. But the push is not done (see https://travis-ci.org/cyclus/rickshaw/builds/347951348#L1373). It seems we need to color the doctr output better. |
Should fix #13 CC @gonuke @FlanFlanagan