Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct failed geoIP attempts showing as USA #381

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@overint
Copy link
Collaborator

overint commented Oct 28, 2017

Currently if the geoIP library does not pick up a country when logging advanced stats, if defaults to USA.
This is incorrect, so I have modified the defaults and changed the query for the map to ignore visits with an empty country.

overint added some commits Oct 28, 2017

@overint

This comment has been minimized.

Copy link
Collaborator Author

overint commented Nov 16, 2017

Any thoughts on this @cydrobolt?

@overint

This comment has been minimized.

Copy link
Collaborator Author

overint commented Mar 27, 2018

It seems I still need a review from you @cydrobolt before my PRs can be merged.

overint added some commits Mar 27, 2018

@overint

This comment has been minimized.

Copy link
Collaborator Author

overint commented May 23, 2018

@cydrobolt
Any thoughts?

Repository owner deleted a comment from overint May 24, 2018

Repository owner deleted a comment from overint May 24, 2018

cydrobolt added a commit that referenced this pull request May 24, 2018

@cydrobolt

This comment has been minimized.

Copy link
Owner

cydrobolt commented May 24, 2018

Merged in f9622d7. Thank you!

@cydrobolt cydrobolt closed this May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.