Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive HTML 5 and better looks #22

Open
wants to merge 14 commits into
base: master
from

Conversation

@animeshmanglik
Copy link

animeshmanglik commented Oct 17, 2013

Using twiiter Bootstrap 2 , made changes to the overall look of the
Pubby, it now incorporates a Responsive Design and makes the whole look
appear much cleaner and visually appealing.
The Velocity Macros have been updated to include the new CSS files and
the structure has been modified.
The whole structure has been made responsive and can now be viewed in
Tablets, Mobile.
A link to the main image being displayed is provided.
Do check out the screenshots.

Using twiiter Bootstrap 2 , made changes to the overall look of the
Pubby, it now incorporates a Responsive Design and makes the whole look
appear much cleaner and visually appealing.
The Velocity Macros have been updated to include the new CSS files and
the structure has been modified.
The whole structure has been made responsive and can now be viewed in
Tablets, Mobile.
A link to the main image being displayed is provided.
Do check out the screenshots.
Placed Screenshot under Docs
Removed the .DS files
@cygri
Copy link
Owner

cygri commented Oct 17, 2013

This looks very nice, it's a huge improvement over Pubby's current rather dated look, and being mobile ready is increasingly important. Boostrap is an excellent choice here I think.

For the public record, I'll paste some comments here that I already sent earlier over email.

  1. The "New look to Table" screenshot seems to indicate that you always break property prefixed names into two lines, like:

    rdfs:
    label

    That's a bad idea in my opinion, and should be reverted to the old behavior where the entire name appears in a single line: rdfs:label.

  2. The screenshots should really not be in the main directory, but underneath /doc, and they should be integrated into the /doc/index.html documentation, perhaps in a new "screenshots" section, so that they show off the new look!

  3. This may be a matter of taste, but the look of normal tables and metadata tables is quite different now. It would be better if they were more similar. (I definitely prefer the look of your normal tables!) The metadata feature has a few other problems as well and may need a bigger overhaul, so don't worry about this.

  4. Another matter of taste: I find the look a bit "monochrome" with only white, black and blue. A few dashes of color here and there might make it look even more appealing :-)

Images:

New look for tables
Metadata table
Image handling
Zoomed out image

Changes in the way description table looks
Breaking of property prefixed - Fixed
Hovering on table rows to highlight content being read
New Screenshot added
@cygri
Copy link
Owner

cygri commented Oct 26, 2013

I've created a new branch, feature-bootstrap, pulled your changes into it (8f73e67, squashed into a single cleaned-up commit), merged them with other recent developments from the master branch (6503072), and finally did some major changes to the layout on top of your changes (d181802).

Your work inspired me to take a closer look at Bootstrap, and to have a go at improving the layout in various ways. I'm quite pleased with the result!

This still needs a bit of work. Most importantly, the layout for the metadata tables is currently broken. I've also only done some very minor testing on mobile, so the CSS may need some fine-tuning again to be up to par with your version in mobile usability.

@animeshmanglik, I would appreciate if you could checkout the feature-bootstrap branch and give it a try. Do you see any problems? Any ideas for improvements? What do you think of the direction that the design has taken?

@cygri
Copy link
Owner

cygri commented Oct 26, 2013

Metadata tables now also have the new layout, as good as it's possible without making deeper changes in the metadata code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.