Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cylc insert --help": no cycle point globbing #3284

Closed
hjoliver opened this issue Aug 12, 2019 · 4 comments

Comments

@hjoliver
Copy link
Contributor

commented Aug 12, 2019

Describe the bug

Cycle point and task name globs do not (and probably should not) work with cylc insert, but command help suggests they do.

REF: https://cylc.discourse.group/t/square-bracket-wildcards-in-cylc-insert-cycle-points/123/2

Release version(s) and/or repository branch(es) affected?

All versions to date.

Steps to reproduce the bug

cylc insert --help

Expected behavior

Don't mention globbing, and/or explain why cylc insert is different to other task-targeting commands in this respect.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@hjoliver hjoliver added the bug label Aug 12, 2019

@hjoliver hjoliver added this to the next-release milestone Aug 12, 2019

@hjoliver hjoliver changed the title insert command help should not mention glob matching insert command help should not mention globbing Aug 12, 2019

@matthewrmshin

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

(I thought task names should glob correctly with task definition?)

@dwsutherland

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

They do work with globing (>.>) ... When I was working with the API, I found it strange that the ZeroMQ endpoint treated it differently (as if it couldn't glob), however it worked with globs.. So I treated it the same as any other task action in the GraphQL setup:

class TaskArgs(InputObjectType):

@dwsutherland

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

(I thought task names should glob correctly with task definition?)

Yeah, maybe it just works on task name not point.

@hjoliver

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Sorry, yes - globbing on insert works with task name, but not cycle point. That makes sense because a task name glob can be matched against "known stuff" - the list of all task names in the suite.

Globbing on cycle point (for insert) doesn't work - we'd have to generate all possible cycle points for matching tasks, and then match against those (possible, but not very easy, and not really in the spirit of "matching existing stuff against a pattern").

Amending description...

@hjoliver hjoliver changed the title insert command help should not mention globbing "cylc insert --help": no cycle point globbing Aug 12, 2019

@sadielbartholomew sadielbartholomew self-assigned this Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.