Don't delay reload of active tasks. #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
1818.reload-active-tasks-now
branch
2 times, most recently
from
5044375
to
61f7950
Compare
hjoliver
force-pushed
the
1818.reload-active-tasks-now
branch
from
61f7950
to
f1daaf3
Compare
| @@ -821,7 +844,6 @@ def job_submission_failed(self): | |||
| msg = "submission failed, %s (after %s)" % (delay_msg, timeout_str) | |||
| self.log(INFO, "job(%02d) " % self.submit_num + msg) | |||
| self.summary['latest_message'] = msg | |||
| self.summary['waiting for reload'] = self.reconfigure_me | |||
hjoliver
force-pushed
the
1818.reload-active-tasks-now
branch
2 times, most recently
from
34e562f
to
f146028
Compare
hjoliver
force-pushed
the
1818.reload-active-tasks-now
branch
2 times, most recently
from
a5f11df
to
5e02e58
Compare
|
Tests pass here. @matthewrmshin - please review/assign. |
|
Looks OK. Tests OK (with and without global configuration) in my environment. @arjclark please review. |
|
Looks OK to me. No problems from the test-battery in my environment. @matthewrmshin informs me he's done some manual testing too to confirm change is working. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1818 - simplify reload logic by not delaying reload of active tasks. Instead just log a warning that the job is already active under the old settings.
Now preserves task outputs across the reload, so there's no need for the delayed reload any more even if task outputs are changed in the reloaded suite definition.