Detect whether version is prerelease #6
Conversation
This can be used in the actions/create-release action
MetRonnie
requested review from
kinow and
wxtim
and removed request for
oliver-sanders
There was a problem hiding this comment.
Looks good to me. With the PRERELEASE defined we should be ready to use the create-release action. That'd be useful for the cylc-ui, where we release the packaged version via GitHub releases.
Thanks @MetRonnie !
| @@ -21,3 +22,22 @@ runs: | |||
| exit 1 | |||
| fi | |||
| echo "VERSION=$VERSION" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Don't remember if I had seen this way to set environment variables in GH actions. But good to learn/remember it 👍 https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
There was a problem hiding this comment.
They changed it last month or so due to a vulnerability in the old way of doing it
| from packaging import version | ||
|
|
||
| ver = version.Version(os.environ['VERSION']) | ||
| is_pre = str(ver.is_prerelease).lower() |
There was a problem hiding this comment.
From the packaging docs
is_prereleaseA boolean value indicating whether this Version instance represents a prerelease and/or development release.
I believe it follows what's defined in PEP-440 for pre-releases:
X.YaN # Alpha release
X.YbN # Beta release
X.YrcN # Release Candidate
X.Y # Final release
So alpha, beta, and release candidates will be treated as pre-releases👍
This can be used in the https://github.com/actions/create-release action