Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
I believe Strehler is pretty big project to have its own Perl::Critic system. However, as long as I'm not the author, I don't really know what you consider good or bad.
So I tried to create some scaffold for you. You can merge it as-is, merge and edit, ask me to change what you want or even don't merge it at all and use it as a inspiration for you own Perl::Critic system :).
I also fixed some problems Perl::Critic showed me.
P. S. I got you repo for Pull request challenge this month.
Hi, great work and thanks for your time spent on Strehler!
I pushed a branch named merge_45, started from yours, if you want to go on collaborating on the issue. What I did on it:
Unfortunatly there's still an open issue. Changing eval "require $class" to load $class broke something, test t/006_extra.t returns now a lot of strange errors. I'm trying to find out how to fix it. If I will have to give up, i'll revert that modification excluding the code from critic
There was a (useless) require in the test script. That plus the Module::Load call made the module been loaded twice, a really bad thing from interpeter point of view!
Here's the commit that fixed: bbdc11a#diff-3856c4a784b9f9ecd515edade68c1b1c
(probably I should get rid of the other require too... but it's working all well right now and I don't want to touch it too much ;-)