Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check = NULL #35

Closed
moodymudskipper opened this issue Sep 7, 2022 · 1 comment · Fixed by #47
Closed

check = NULL #35

moodymudskipper opened this issue Sep 7, 2022 · 1 comment · Fixed by #47

Comments

@moodymudskipper
Copy link
Collaborator

moodymudskipper commented Sep 7, 2022

The check arg is useful but the failures are distracting and not always helpful.

Let's make check = NULL the default.

It works like check = TRUE if the check is satisfied

If the check is not satisfied we just mention it or summarise it in a couple discrete lines at the bottom, and inform the user they can get details on the last issues with construct_issues()

  • check = NULL doesn't fail, it returns the rich object described in Return rich object + print method #36 but the user still sees if the object was not recreated perfectly.
  • check = TRUE does fail, and returns the rich object if success.
  • check = FALSE returns the rich object with an empty waldo_compare let
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant