Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: deprecate dm_squash_to_tbl() and instead provide argument .recursive for dm_flatten_to_tbl(); rename start to .start and join to .join (#1272) #1324

Merged
merged 23 commits into from Jul 21, 2022

Conversation

TSchiefer
Copy link
Member

closes #1272

@TSchiefer TSchiefer requested a review from krlmlr July 20, 2022 16:11
github-actions bot and others added 6 commits July 20, 2022 17:39
@krlmlr krlmlr changed the title api: deprecate dm_squash_to_tbl() and instead provide argument recursive for dm_flatten_to_tbl() api: deprecate dm_squash_to_tbl() and instead provide argument .recursive for dm_flatten_to_tbl() Jul 21, 2022
@krlmlr krlmlr changed the title api: deprecate dm_squash_to_tbl() and instead provide argument .recursive for dm_flatten_to_tbl() api: deprecate dm_squash_to_tbl() and instead provide argument .recursive for dm_flatten_to_tbl(); rename start to .start and join to .join (#1272) Jul 21, 2022
…fig-os-ubuntu-18-04-r-release-test-src-test-postgres-covr-true-desc-Postgres-with-covr

Snapshot updates for rcc-full ({"config":{"os":"ubuntu-18.04","r":"release","test-src":"test-postgres","covr":true,"desc":"Postgres with covr"}})
…fig-os-ubuntu-18-04-r-release-test-src-test-maria-covr-true-desc-MariaDB-with-covr

Snapshot updates for rcc-full ({"config":{"os":"ubuntu-18.04","r":"release","test-src":"test-maria","covr":true,"desc":"MariaDB with covr"}})
@krlmlr
Copy link
Collaborator

krlmlr commented Jul 21, 2022

@TSchiefer: I went "all in" here. What did I miss?

@krlmlr krlmlr merged commit 6eac8f8 into main Jul 21, 2022
@krlmlr krlmlr deleted the f-1272-flatten-recursive branch July 21, 2022 09:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Could flatten and squash be the same function with a different argument?
2 participants