From 6078bd4986703329d71bd755c04aa4209fa4461a Mon Sep 17 00:00:00 2001 From: Cheng-Yu Pai Date: Thu, 8 Oct 2015 16:40:27 -0700 Subject: [PATCH] single return point --- .../NumericLiteralNeedsUnderscoreCheck.java | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.java b/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.java index 5b69c2b27..c23fd606b 100644 --- a/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.java +++ b/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/NumericLiteralNeedsUnderscoreCheck.java @@ -237,19 +237,21 @@ private boolean passesCheck(String rawLiteral) */ private Type getNumericType(String rawLiteral) { - if (rawLiteral.length() < 2) { - return Type.DECIMAL; - } Type type; - String prefix = rawLiteral.substring(0, 2); - if (prefix.equals("0x")) { - type = Type.HEX; - } - else if (prefix.equals("0b")) { - type = Type.BINARY; + if (rawLiteral.length() < 2) { + type = Type.DECIMAL; } else { - type = Type.DECIMAL; + String prefix = rawLiteral.substring(0, 2); + if (prefix.equals("0x")) { + type = Type.HEX; + } + else if (prefix.equals("0b")) { + type = Type.BINARY; + } + else { + type = Type.DECIMAL; + } } return type; }