Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a node-16 executor? #368

Closed
adam-lynch opened this issue Feb 4, 2022 · 6 comments
Closed

Can we get a node-16 executor? #368

adam-lynch opened this issue Feb 4, 2022 · 6 comments

Comments

@adam-lynch
Copy link

There should be an executor to run on node 16. The max is 14 according to https://circleci.com/developer/orbs/orb/cypress-io/cypress#executors.

I haven't ran into an issue yet but we've had some local issues with our postinstall scripts on node 14 so we're bumping to 16 and I want to run the Cypress job on 16 too.

See https://nodejs.org/en/about/releases/; node 16, 17, and 18 should probably be supported.

@essential-randomness
Copy link

Came here to ask the same thing :)

essential-randomness added a commit to essential-randomness/circleci-orb that referenced this issue Feb 15, 2022
See cypress-io#368 

(I'm using the github web interface and I'm unsure what's going to happen when I click "propose changes". If this opens a PR directly, I'll update the issue once it's tested.)
@FinnLawrence
Copy link

For anyone who needs Node 16 support in the meantime, I have set our builds up to use a customised docker executor from Cypress's list here: https://github.com/cypress-io/cypress-docker-images/tree/master/browsers

Example config:

version: 2.1
orbs:
  cypress: cypress-io/cypress@1.29.0
executors:
  with-chrome:
    resource_class: small
    docker:
      - image: "cypress/browsers:node16.13.0-chrome95-ff94"
workflows:
  build:
    jobs:
      - cypress/install:
          executor: with-chrome
          ....
      - [your other jobs]
          executor: with-chrome
          ....

@fasani-tx
Copy link

Any update on this?

Node 16 is more than a year old already is LTS.

@fasani-tx
Copy link

This was now merged. Maybe this issue can be closed.
#376

@admah
Copy link
Contributor

admah commented Jul 20, 2022

Closing this at v2.1.0 of the orb now contains this.

@admah admah closed this as completed Jul 20, 2022
@adam-lynch
Copy link
Author

Thanks a lot @admah!

My tests run fine. I now see the "CertVerifyProcBuiltin" error (cypress-io/cypress#22128). I assume this is unrelated to the executor and I've only starting seeing it because my Circle cache was cleared due to changing the Node version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants