fix: Prevent losing click event during icon replacement #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba9c422 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
karl/fix/prevent-losing-click-event-during-icon-replacement
|
| Run status |
|
| Run duration | 05m 23s |
| Commit |
|
| Committer | Karl Snyder |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
236
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
7.43%
|
|
|---|---|
|
Untested elements
|
308
|
|
Tested elements
|
26
|
Accessibility
99.43%
|
|
|---|---|
|
Failed rules
|
0 critical
2 serious
0 moderate
1 minor
|
|
Failed elements
|
23
|
jennifer-shehane
approved these changes
Jun 12, 2025
karlsnyder0
deleted the
karl/fix/prevent-losing-click-event-during-icon-replacement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes prevent losing click event during icon replacement after transient active change update to fix animated icon not working.