add stop circle icon #602
add stop circle icon #602
Conversation
🦋 Changeset detectedLatest commit: ecceecf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,22 @@ | |||
| <svg viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
@mabela416 Can we use the simpler code that eliminates the mask?
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M8 16C12.4183 16 16 12.4183 16 8C16 3.58172 12.4183 0 8 0C3.58172 0 0 3.58172 0 8C0 12.4183 3.58172 16 8 16ZM5 4C4.44772 4 4 4.44772 4 5V11C4 11.5523 4.44772 12 5 12H11C11.5523 12 12 11.5523 12 11V5C12 4.44772 11.5523 4 11 4H5Z" fill="#5A5F7A"/>
</svg>
ryanjwilke
left a comment
ryanjwilke
left a comment
There was a problem hiding this comment.
I left one comment that would simplify the icon code quite a bit.
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
mabel/stop-circle-icon
|
| Run status |
|
| Run duration | 05m 25s |
| Commit |
|
| Committer | mabela416 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
236
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
7.43%
|
|
|---|---|
|
Untested elements
|
308
|
|
Tested elements
|
26
|
Accessibility
99.43%
|
|
|---|---|
|
Failed rules
|
0 critical
2 serious
0 moderate
1 minor
|
|
Failed elements
|
23
|
| clip-rule="evenodd" | ||
| d="M8 16C12.4183 16 16 12.4183 16 8C16 3.58172 12.4183 0 8 0C3.58172 0 0 3.58172 0 8C0 12.4183 3.58172 16 8 16ZM5 4C4.44772 4 4 4.44772 4 5V11C4 11.5523 4.44772 12 5 12H11C11.5523 12 12 11.5523 12 11V5C12 4.44772 11.5523 4 11 4H5Z" | ||
| fill="currentColor" | ||
| class="icon-light" |
There was a problem hiding this comment.
Seems to me that the class should be "icon-dark", not "icon-light". @mabela416
Does this even matter when the icon is using a single color? @ryanjwilke
There was a problem hiding this comment.
I think icon-light is the fill typically right? If so, this makes sense to me. This is basically a solid icon with no strokes.
No description provided.