New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Cypress logo scaling issue #1032

Open
Bkucera opened this Issue Oct 10, 2018 · 2 comments

Comments

4 participants
@Bkucera
Member

Bkucera commented Oct 10, 2018

docs.cypress.io:

current (css width 100px)

image

expected (css width 102px)

image

docs cypress logo looks blurred because it's scaled to 100px. We should consider using an image already sized.

@Montette

This comment has been minimized.

Show comment
Hide comment
@Montette

Montette Oct 19, 2018

I see also something else, I think it should be vertically centered

shu_wda2do0

And on the screen that are exactly 769px it looks like below

shu_k9k2919

is this the intended effect or it should be fixed? I could deal with this issue

Montette commented Oct 19, 2018

I see also something else, I think it should be vertically centered

shu_wda2do0

And on the screen that are exactly 769px it looks like below

shu_k9k2919

is this the intended effect or it should be fixed? I could deal with this issue

@richdouglasevans

This comment has been minimized.

Show comment
Hide comment
@richdouglasevans

richdouglasevans Oct 19, 2018

Contributor

Good spot Montette! Go for it ✌️

Contributor

richdouglasevans commented Oct 19, 2018

Good spot Montette! Go for it ✌️

pertrai1 added a commit to pertrai1/cypress-documentation that referenced this issue Oct 19, 2018

fix(logo): Adjust position and size of logo
This fixes issue with position of logo in mobile view along with the desired size of the logo being adjusted based on the issue reported.

closes cypress-io#1032

pertrai1 added a commit to pertrai1/cypress-documentation that referenced this issue Oct 19, 2018

fix(logo): Fixes position and size of logo
Based on the issue reported, the logo is now positioned accordingly and is the size expected.

closes cypress-io#1032

@pertrai1 pertrai1 referenced a pull request that will close this issue Oct 19, 2018

Open

fix(logo): Fixes position and size of logo #1076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment