New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {home} and {end} to supported sequences in cy.type() #1344

Open
jennifer-shehane opened this Issue Jan 24, 2019 · 6 comments

Comments

3 participants
@silviuavram

This comment has been minimized.

Copy link

silviuavram commented Jan 24, 2019

I can take this one, since it's following up my changes.

@silviuavram silviuavram referenced a pull request that will close this issue Jan 24, 2019

Open

3.2.0 Release: adds {home} and {end} to cy.type() #1347

@silviuavram

This comment has been minimized.

Copy link

silviuavram commented Jan 24, 2019

Created the PR, @jennifer-shehane . Please take a look. Can you also tell me why for Up/Arrow it says that the cursor does not move, but we actually move it? What am I missing there?

@jennifer-shehane

This comment has been minimized.

Copy link
Member Author

jennifer-shehane commented Jan 24, 2019

@Bkucera ^ Can you explain the up/arrow logic?

@Bkucera

This comment has been minimized.

Copy link
Member

Bkucera commented Jan 24, 2019

@silviuavram good find, our docs need to be updated, since the up/down arrow does move the cursor as of 3.0.3

you could go ahead and update that if you want

@Bkucera

This comment has been minimized.

Copy link
Member

Bkucera commented Jan 24, 2019

should read "moves cursor up" and "moves cursor down" to remain consistent

@silviuavram

This comment has been minimized.

Copy link

silviuavram commented Jan 24, 2019

pushed the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment