Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Proxy Configuration to References #1486
jennifer-shehane left a comment
Yeah, I don't think this is a great spot. This page has currently only been used for any values that could be set inside
I'm ok with creating a new guide to be honest. I think shorter, more specific guides are a better direction for us to go in.
In general feedback:
I understand you have other work - so it's fine if you do not make all of these updates. I can pick it up.
@jennifer-shehane Thanks for the review. I moved the proxy configuration to it's own page in References, added some explanations for why Cypress needs a proxy to work and what that looks like, clarified the environment variables thing, and added some of those keywords that people might search for. I also added a section on how to check out their proxy config through the UI.
It might still need some work, so if you want to make some changes, please feel free to pick it up.
Re: adding info on how they can check if they're behind a proxy, I'm not sure about that. There are tools like http://amibehindaproxy.com/ that do some simple HTTP header checks, but it's easy to get a false positive/false negative and it might just confuse users more. I thought about saying "Unsure if you're behind a network proxy? Contact your administrator." in an infobox but I felt like that might be too obvious to bother writing. I'm open to suggestions.