Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2234 notes missing #2242

Merged
merged 4 commits into from Nov 12, 2019
Merged

Issue 2234 notes missing #2242

merged 4 commits into from Nov 12, 2019

Conversation

@andrew-codes
Copy link
Contributor

andrew-codes commented Nov 12, 2019

#2196 introduced #2234; where no notes were rendered throughout the docs site. This PR addresses this; primarily by actually returning the parsed notes' value.

The issue is may be seen on the configuration page of the docs site or locally

Before screenshot (without notes)
image

and, correctly working, after:
image

parsed markdown content can contain a trailing new line
The parsed value of the markdown should be returned in order for it to be rendered.
@andrew-codes andrew-codes self-assigned this Nov 12, 2019
Copy link
Contributor

oak-wildwood left a comment

Looks good. Thanks for the quick fix!

This was previously done via `gulp pre:build` and only for production builds. Without doing this in dev, third party deps are not loaded and fail tests.
Copy link
Contributor

oak-wildwood left a comment

Nice test!

@andrew-codes andrew-codes merged commit 1c636dd into develop Nov 12, 2019
15 checks passed
15 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: docs-tests Your tests passed on CircleCI!
Details
cypress: api_spec.js (develop) 2 tests passed in 00:16
Details
cypress: changelog_spec.js (develop) 2 tests passed in 00:01
Details
cypress: contentful_banners_spec.js (develop) 7 tests passed in 00:02
Details
cypress: i18n_spec.js (develop) 4 tests passed in 00:07
Details
cypress: main_nav_spec.js (develop) 6 tests passed in 00:06
Details
cypress: main_spec.js (develop) 6 tests passed in 00:04
Details
cypress: mobile_spec.js (develop) 6 tests passed in 00:06
Details
cypress: notes_spec.js (develop) 1 test passed in 813ms
Details
cypress: page_header_spec.js (develop) 2 tests passed in 00:16
Details
cypress: pagination_spec.js (develop) 3 tests passed in 00:11
Details
cypress: sidebar_spec.js (develop) 2 tests passed in 00:12
Details
cypress: table_of_contents.js (develop) 1 test passed in 00:02
Details
license/cla Contributor License Agreement is signed.
Details
@andrew-codes

This comment has been minimized.

Copy link
Contributor Author

andrew-codes commented Nov 18, 2019

Closes #2234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.