fixed broken links in mobile nav #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat have a redirect property instead of a slug property
robertguss
changed the title
amirrustam
approved these changes
Sep 20, 2021
|
Link to Slack conversation. Axolo's notification on Slack Channel creation20/09/2021 05:50 PM: robert robert has joined the channel 05:50 PM: axolo set the channel topic: Branch: dx-580-fix-broken-links-in-mobile-nav | Link to PR : #4097 06:00 PM: amir amir has joined the channel Start of the conversation20/09/2021 06:00 PM: axolo 🥳 amirrustam approved this pull request ! 06:01 PM: axolo The pull request was closed or merged, congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broken links in the mobile nav were caused by the link items in the
_data/sidebar.jsonnot having a slug property. I updated theAppHeaderMobileSection.vuecomponent to also render items if they have a redirect property to fix the broken links.