From 6a5c5d2d1b2248605daf9fc2c299633b05710a78 Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 11:20:08 -0500 Subject: [PATCH 01/11] changelog --- content/_changelogs/9.5.4.md | 65 ++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 content/_changelogs/9.5.4.md diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md new file mode 100644 index 0000000000..371219ed8c --- /dev/null +++ b/content/_changelogs/9.5.4.md @@ -0,0 +1,65 @@ +## 9.5.4 + +_Released 4/11/2022_ + +**Bugfixes:** + +- Updates were made to silence Electron warnings related to being unable to + connect to dbus. These errors are normal and expected, and do not result in + test failures. Because they are always present when running Electron inside + docker containers, it has incorrectly led people to believe it is the + root-cause of an error within their test run. By silencing these errors, it + will improve the debug experience to allow users to focus on meaningful + warning and error messages. Fixed + [#19299](https://github.com/cypress-io/cypress/issues/19299). +- Updates were made to ensure that all `*.enabled` events are sent if Cypress + becomes disconnected from the Chrome DevTools Protocol and must re-establish a + connection to ensure all command logs are displayed to the user. This fixes an + issue where some command logs, like download or network events, are missing + once Cypress has disconnected and then reconnected to the Chrome DevTools + Protocol. Fixed [#20618](https://github.com/cypress-io/cypress/issues/20618). +- Fixed in issue where `cy.type('{enter}')` was not sending the Enter key for + Firefox `v98+`. This was not an issue with Firefox `v97` and below. Fixed + [#20562](https://github.com/cypress-io/cypress/issues/20562). +- Fixed a regression in [9.3.0](/guides/references/changelog#9-3-0) where + updates made to split glob patterns provided to the `--spec` CLI parameter on + commas was incorrectly splitting the patterns. Fixes + [#20794](https://github.com/cypress-io/cypress/issues/20794). +- Fixed an issue with `cy.root` to respect the + [`timeout`](/api/commands/root#Arguments) option passed to the command. + Previously, when the `timeout` option was provided, it was ignored and the + default timeout was used. Fixed + [#19985](https://github.com/cypress-io/cypress/issues/19985). +- Updates were made to decrease the length of the Cypress cache path for Windows + to ensure installing pre-release versions of the Cypress binary are within the + maximum path length of 260 characters. This should improve the experience for + Windows users since it's been observed the path length has exceed the default + maximum, which resulted in install failures. Fixed in + [#20961](https://github.com/cypress-io/cypress/pulls/20961). +- Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would + sometimes throw an expected error on navigation with `cy.back()` and + `cy.go()`. The changes in `9.2.0` were made to mitigate the Chrome ` v97+` + change which always triggered an extra load event when an iframe navigated due + to a url hashchange. This change was made to maintain how Cypress handles + navigation. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749) + and [#20539](https://github.com/cypress-io/cypress/issues/20539). +- Corrected the typescript type for a cookie which was incorrectly types as + `any` when the correct type is `Cookie`. Fixed in + [#20513](https://github.com/cypress-io/cypress/pull/20513). +- Add the missing `Cypress.Command.addAll()` typescript types. Fixed + [#18886](https://github.com/cypress-io/cypress/issue/18886). +- Fixed an uncommon error observed in `cy.session` where an error was thrown + when no cookies had been set for the session and the user clicks the session + command log to view additional details in the dev tools console. Fixed in + [#20946](https://github.com/cypress-io/cypress/pull/20946). + +**Dependency Updates:** + +- Upgraded `ansi-regex` dependency from `4.1.0` to `4.1.1` to address the + [CVE-2021-3807](https://nvd.nist.gov/vuln/detail/CVE-2021-3807) NVD security + vulnerability. Addressed in + [#20807](https://github.com/cypress-io/cypress/pull/20807). +- Upgraded `plist` dependency from `3.0.4` to `3.0.5` to address the + [CVE-2022-22912](https://nvd.nist.gov/vuln/detail/CVE-2022-22912) NVD security + vulnerability. Addressed in + [#20808](https://github.com/cypress-io/cypress/pull/20808). From 18c3f9990acf1842a16b5695d268e085231a8a8a Mon Sep 17 00:00:00 2001 From: Kukhyeon Heo Date: Tue, 12 Apr 2022 01:22:21 +0900 Subject: [PATCH 02/11] docs: Document Cypress.Commands.addAll() (#4414) Co-authored-by: Emily Rohrbough --- content/api/cypress-api/custom-commands.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/content/api/cypress-api/custom-commands.md b/content/api/cypress-api/custom-commands.md index 318ba4206a..eb3ba37eb0 100644 --- a/content/api/cypress-api/custom-commands.md +++ b/content/api/cypress-api/custom-commands.md @@ -21,6 +21,8 @@ evaluated via an import statement in your ```javascript Cypress.Commands.add(name, callbackFn) Cypress.Commands.add(name, options, callbackFn) +Cypress.Commands.addAll(callbackObj) +Cypress.Commands.addAll(options, callbackObj) Cypress.Commands.overwrite(name, callbackFn) ``` @@ -30,6 +32,10 @@ Cypress.Commands.overwrite(name, callbackFn) ```javascript Cypress.Commands.add('login', (email, pw) => {}) +Cypress.Commands.addAll({ + login(email, pw) {}, + visit(orig, url, options) {}, +}) Cypress.Commands.overwrite('visit', (orig, url, options) => {}) ``` @@ -43,6 +49,10 @@ The name of the command you're either adding or overwriting. Pass a function that receives the arguments passed to the command. +** callbackObj** **_(Object)_** + +An object with `callbackFn`s as properties. + ** options** **_(Object)_** Pass in an options object to define the implicit behavior of the custom command. From 1ecafad1917170f622dab6ca87994c1459a4cc84 Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:07:01 -0500 Subject: [PATCH 03/11] clean up --- content/_changelogs/9.5.4.md | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 371219ed8c..e7a3b00a3b 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -18,12 +18,12 @@ _Released 4/11/2022_ issue where some command logs, like download or network events, are missing once Cypress has disconnected and then reconnected to the Chrome DevTools Protocol. Fixed [#20618](https://github.com/cypress-io/cypress/issues/20618). -- Fixed in issue where `cy.type('{enter}')` was not sending the Enter key for +- Fixed an issue where `cy.type('{enter}')` was not sending the Enter key for Firefox `v98+`. This was not an issue with Firefox `v97` and below. Fixed [#20562](https://github.com/cypress-io/cypress/issues/20562). -- Fixed a regression in [9.3.0](/guides/references/changelog#9-3-0) where - updates made to split glob patterns provided to the `--spec` CLI parameter on - commas was incorrectly splitting the patterns. Fixes +- Fixed a regression in [9.3.0](/guides/references/changelog#9-3-0) where glob + patterns provided to the `--spec` CLI parameter was incorrectly splitting the + patterns in unexpected places when it should have split on commas. Fixes [#20794](https://github.com/cypress-io/cypress/issues/20794). - Fixed an issue with `cy.root` to respect the [`timeout`](/api/commands/root#Arguments) option passed to the command. @@ -39,20 +39,26 @@ _Released 4/11/2022_ - Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would sometimes throw an expected error on navigation with `cy.back()` and `cy.go()`. The changes in `9.2.0` were made to mitigate the Chrome ` v97+` - change which always triggered an extra load event when an iframe navigated due - to a url hashchange. This change was made to maintain how Cypress handles - navigation. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749) - and [#20539](https://github.com/cypress-io/cypress/issues/20539). -- Corrected the typescript type for a cookie which was incorrectly types as + change which always emitted an extra load event to an iframe when a navigation + change was triggered by a url hashchange. This change was made to maintain how + Cypress handles navigation. Fixed + [#19749](https://github.com/cypress-io/cypress/issues/19749) and + [#20539](https://github.com/cypress-io/cypress/issues/20539). +- Corrected the typescript type for a cookie which was incorrectly typed as `any` when the correct type is `Cookie`. Fixed in [#20513](https://github.com/cypress-io/cypress/pull/20513). -- Add the missing `Cypress.Command.addAll()` typescript types. Fixed +- Added the missing `Cypress.Command.addAll()` typescript types. Fixed [#18886](https://github.com/cypress-io/cypress/issue/18886). - Fixed an uncommon error observed in `cy.session` where an error was thrown when no cookies had been set for the session and the user clicks the session command log to view additional details in the dev tools console. Fixed in [#20946](https://github.com/cypress-io/cypress/pull/20946). +**Misc:** + +- A minor visual update was made to the `cy.sessions` command log visuals. Fixed + [#20433](https://github.com/cypress-io/cypress/issues/20433). + **Dependency Updates:** - Upgraded `ansi-regex` dependency from `4.1.0` to `4.1.1` to address the From 4b822813af8455f5583e8e4ec97dcf9d4b1d4e21 Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:35:13 -0500 Subject: [PATCH 04/11] Update content/_changelogs/9.5.4.md Co-authored-by: Jennifer Shehane --- content/_changelogs/9.5.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index e7a3b00a3b..6a0a80b6ad 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -25,7 +25,7 @@ _Released 4/11/2022_ patterns provided to the `--spec` CLI parameter was incorrectly splitting the patterns in unexpected places when it should have split on commas. Fixes [#20794](https://github.com/cypress-io/cypress/issues/20794). -- Fixed an issue with `cy.root` to respect the +- Fixed an issue with `cy.root()` to respect the [`timeout`](/api/commands/root#Arguments) option passed to the command. Previously, when the `timeout` option was provided, it was ignored and the default timeout was used. Fixed From 56be9b8384060f1bea75833a573867ca29d2f95d Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:35:23 -0500 Subject: [PATCH 05/11] Update content/_changelogs/9.5.4.md Co-authored-by: Jennifer Shehane --- content/_changelogs/9.5.4.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 6a0a80b6ad..a17e3ed632 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -32,9 +32,7 @@ _Released 4/11/2022_ [#19985](https://github.com/cypress-io/cypress/issues/19985). - Updates were made to decrease the length of the Cypress cache path for Windows to ensure installing pre-release versions of the Cypress binary are within the - maximum path length of 260 characters. This should improve the experience for - Windows users since it's been observed the path length has exceed the default - maximum, which resulted in install failures. Fixed in + maximum path length of 260 characters. Fixed in [#20961](https://github.com/cypress-io/cypress/pulls/20961). - Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would sometimes throw an expected error on navigation with `cy.back()` and From feffb23a23758060e1c1d70f58287d3454ca163e Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:35:37 -0500 Subject: [PATCH 06/11] Update content/_changelogs/9.5.4.md Co-authored-by: Jennifer Shehane --- content/_changelogs/9.5.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index a17e3ed632..73e90dc066 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -49,7 +49,7 @@ _Released 4/11/2022_ [#18886](https://github.com/cypress-io/cypress/issue/18886). - Fixed an uncommon error observed in `cy.session` where an error was thrown when no cookies had been set for the session and the user clicks the session - command log to view additional details in the dev tools console. Fixed in + command log to view additional details in the DevTools console. Fixed in [#20946](https://github.com/cypress-io/cypress/pull/20946). **Misc:** From a3b549e7b7790ee77d3a78b1493745af94410c0c Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:37:57 -0500 Subject: [PATCH 07/11] pr feedback --- content/_changelogs/9.5.4.md | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 73e90dc066..464fc17065 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -31,31 +31,28 @@ _Released 4/11/2022_ default timeout was used. Fixed [#19985](https://github.com/cypress-io/cypress/issues/19985). - Updates were made to decrease the length of the Cypress cache path for Windows - to ensure installing pre-release versions of the Cypress binary are within the - maximum path length of 260 characters. Fixed in - [#20961](https://github.com/cypress-io/cypress/pulls/20961). + to ensure + [installing pre-release versions](/guides/getting-started/installing-cypress#Install-pre-release-version) + of the Cypress binary are within the maximum path length of 260 characters. + Fixed in [#20961](https://github.com/cypress-io/cypress/pulls/20961). - Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would sometimes throw an expected error on navigation with `cy.back()` and - `cy.go()`. The changes in `9.2.0` were made to mitigate the Chrome ` v97+` - change which always emitted an extra load event to an iframe when a navigation - change was triggered by a url hashchange. This change was made to maintain how - Cypress handles navigation. Fixed - [#19749](https://github.com/cypress-io/cypress/issues/19749) and - [#20539](https://github.com/cypress-io/cypress/issues/20539). -- Corrected the typescript type for a cookie which was incorrectly typed as + `cy.go()`. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749) + and [#20539](https://github.com/cypress-io/cypress/issues/20539). +- Corrected the Typescript type for a cookie which was incorrectly typed as `any` when the correct type is `Cookie`. Fixed in [#20513](https://github.com/cypress-io/cypress/pull/20513). -- Added the missing `Cypress.Command.addAll()` typescript types. Fixed +- Added the missing `Cypress.Command.addAll()` Typescript types. Fixed [#18886](https://github.com/cypress-io/cypress/issue/18886). -- Fixed an uncommon error observed in `cy.session` where an error was thrown +- Fixed an uncommon error observed in `cy.session()` where an error was thrown when no cookies had been set for the session and the user clicks the session command log to view additional details in the DevTools console. Fixed in [#20946](https://github.com/cypress-io/cypress/pull/20946). **Misc:** -- A minor visual update was made to the `cy.sessions` command log visuals. Fixed - [#20433](https://github.com/cypress-io/cypress/issues/20433). +- A minor visual update was made to the `cy.session()` command log visuals. + Fixed [#20433](https://github.com/cypress-io/cypress/issues/20433). **Dependency Updates:** From 4b225b71d02b8b452d642aea2603020fd584355f Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:44:37 -0500 Subject: [PATCH 08/11] add missing entry --- content/_changelogs/9.5.4.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 464fc17065..5712076560 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -35,6 +35,10 @@ _Released 4/11/2022_ [installing pre-release versions](/guides/getting-started/installing-cypress#Install-pre-release-version) of the Cypress binary are within the maximum path length of 260 characters. Fixed in [#20961](https://github.com/cypress-io/cypress/pulls/20961). +- Fixed a regression in [8.6.0](/guides/references/changelog#8-6-0) to which + prevented `cy.paused()` from correctly executing when passing the + `--headed --no-exit` CLI flags to `cypress run`. Fixed + [#20745](https://github.com/cypress-io/cypress/issues/20745). - Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would sometimes throw an expected error on navigation with `cy.back()` and `cy.go()`. Fixed [#19749](https://github.com/cypress-io/cypress/issues/19749) From 41cf1b43ec8e3fdc2e9fd214067f025db226445d Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 12:44:52 -0500 Subject: [PATCH 09/11] Update content/_changelogs/9.5.4.md Co-authored-by: Chris Breiding --- content/_changelogs/9.5.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 5712076560..0fdff5a150 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -12,7 +12,7 @@ _Released 4/11/2022_ will improve the debug experience to allow users to focus on meaningful warning and error messages. Fixed [#19299](https://github.com/cypress-io/cypress/issues/19299). -- Updates were made to ensure that all `*.enabled` events are sent if Cypress +- Updates were made to ensure that all `*.enable` events are sent if Cypress becomes disconnected from the Chrome DevTools Protocol and must re-establish a connection to ensure all command logs are displayed to the user. This fixes an issue where some command logs, like download or network events, are missing From ded906d325f2d5186e1958988ca3c3c5798c6b6f Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 13:43:48 -0500 Subject: [PATCH 10/11] Update content/_changelogs/9.5.4.md Co-authored-by: Jennifer Shehane --- content/_changelogs/9.5.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index 0fdff5a150..a0f886b9bf 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -36,7 +36,7 @@ _Released 4/11/2022_ of the Cypress binary are within the maximum path length of 260 characters. Fixed in [#20961](https://github.com/cypress-io/cypress/pulls/20961). - Fixed a regression in [8.6.0](/guides/references/changelog#8-6-0) to which - prevented `cy.paused()` from correctly executing when passing the + prevented `.pause()` from correctly executing when passing the `--headed --no-exit` CLI flags to `cypress run`. Fixed [#20745](https://github.com/cypress-io/cypress/issues/20745). - Fixed a regression in [9.2.0](/guides/references/changelog#9-2-0) which would From c7333cb6a5e2d9c5ff6581c71eb537d5c28e5ba0 Mon Sep 17 00:00:00 2001 From: Emily Rohrbough Date: Mon, 11 Apr 2022 13:43:53 -0500 Subject: [PATCH 11/11] Update content/_changelogs/9.5.4.md Co-authored-by: Jennifer Shehane --- content/_changelogs/9.5.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/_changelogs/9.5.4.md b/content/_changelogs/9.5.4.md index a0f886b9bf..09ca00394f 100644 --- a/content/_changelogs/9.5.4.md +++ b/content/_changelogs/9.5.4.md @@ -35,7 +35,7 @@ _Released 4/11/2022_ [installing pre-release versions](/guides/getting-started/installing-cypress#Install-pre-release-version) of the Cypress binary are within the maximum path length of 260 characters. Fixed in [#20961](https://github.com/cypress-io/cypress/pulls/20961). -- Fixed a regression in [8.6.0](/guides/references/changelog#8-6-0) to which +- Fixed a regression in [8.6.0](/guides/references/changelog#8-6-0) which prevented `.pause()` from correctly executing when passing the `--headed --no-exit` CLI flags to `cypress run`. Fixed [#20745](https://github.com/cypress-io/cypress/issues/20745).