Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Heroku CI support #324

Closed
Pro777 opened this issue Nov 12, 2019 · 11 comments
Closed

Remove mention of Heroku CI support #324

Pro777 opened this issue Nov 12, 2019 · 11 comments
Assignees

Comments

@Pro777
Copy link

Pro777 commented Nov 12, 2019

Heroku's cedar-14 stack is now EOL.

The heroku buildpack required for Cypress to function is not compatible with newer stacks, so can references to compatibility with Heroku CI be removed?

@flotwig
Copy link
Contributor

flotwig commented Nov 12, 2019

Hey @Pro777, yeah, I tried updating the stack to heroku-18 in #325 and it fails with this error:

-----> Xvfb Google Chrome app detected
 !     The Google Chrome Xvfb buildpack is only supported on Cedar-14.
 !     For newer stacks you must instead use Google Chrome Buildpack,
 !     which runs Chrome in headless mode without Xvfb.
 !     For more details use:
 !     https://devcenter.heroku.com/articles/heroku-ci#known-issues

I don't think that Heroku CI should be removed, as cedar-14 still "works", but it is very old and definitely needs to be updated. I see @bahmutov has run in to this before: #214

I don't see why xvfb wouldn't work in heroku-18, so I think if the buildpack was updated to work with heroku-18, this could be fixed.


Or, cypress-io/cypress#832 would make Cypress compatible with Chrome Headless, and no xvfb would be needed.

@bahmutov
Copy link
Contributor

Well, cedar-14 is mostly failing with SIGILL like #385 so it would be nice to fully support headless Cypress (right now we can do headless browser mode, but not Cypress itself, right @flotwig)

@flotwig
Copy link
Contributor

flotwig commented Mar 18, 2020

correct @bahmutov, Electron still needs a display manager to run, so we still need xvfb-run just for Electron... once we remove Electron from cypress's core, it will not need xvfb for headless mode

@bahmutov
Copy link
Contributor

I will disable our CI Heroku project, because it just keeps failing, breaking our status checks, but I will keep this issue open, because once we remove Electron we should enable it back

@erwanriou
Copy link

Ok interesting, I was fighting with heroku and not understunding why i had this SIGILL Error since i was folowing all the steps. I had the project detected in cypress dashboard (but no info about it). So this is due to this deprecated build of chrome.

So @bahmutov do we have a roadmap of when electron will be removed?

@jennifer-shehane
Copy link
Member

You can follow the issue about removing Electron from Cypress core here: cypress-io/cypress#3899

@Pro777
Copy link
Author

Pro777 commented Aug 13, 2020

Cedar-14 stack EOL has been delayed until November 2, 2020 due to COVID-19.

@savannahp
Copy link

I am currently writing a bunch of cypress test right now and we use Heroku CLI, will this not work if we want to make it part of the pipeline?

@bahmutov
Copy link
Contributor

Unfortunately because of Heroku limitations I don't think Cypress can run on it unless we make it fully headless so it does not need xvfb. I would suggest trying another CI that could even be triggered after Heroku finishes the deploy

@xyNNN
Copy link

xyNNN commented Jun 7, 2021

I would like to use cypress on the heroku ci. Is there no other way to make it work?

@sec0ndhand
Copy link

I'm sorry this issue got re-opened, but it looks like there is some hope with this issue/pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants