Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test login via GitHub impossible with U2F keys #1162

Closed
bootstraponline opened this issue Jan 7, 2018 · 7 comments
Closed

Cypress test login via GitHub impossible with U2F keys #1162

bootstraponline opened this issue Jan 7, 2018 · 7 comments

Comments

@bootstraponline
Copy link

@bootstraponline bootstraponline commented Jan 7, 2018

Current behavior:

Log in errors.

Desired behavior:

Log in works.

How to reproduce:

Log in with a GitHub account that has U2F enabled using a hardware key.

Additional Info (images, stack traces, etc)

image

  • Operating System: Windows 10
  • Cypress Version: 1.4.1
  • Browser Version: Google Chrome Version 63.0.3239.132 (Official Build) (64-bit)
@bootstraponline bootstraponline changed the title Cypress test login via GitHub impossible with 2FA Cypress test login via GitHub impossible with 2FA keys Jan 7, 2018
@brian-mann
Copy link
Member

@brian-mann brian-mann commented Jan 7, 2018

Are you referring to logging into Github while inside of our Desktop Application?

@bootstraponline
Copy link
Author

@bootstraponline bootstraponline commented Jan 7, 2018

Are you referring to logging into Github while inside of our Desktop Application?

Yes

@bahmutov
Copy link
Collaborator

@bahmutov bahmutov commented Jan 7, 2018

@bootstraponline
Copy link
Author

@bootstraponline bootstraponline commented Jan 7, 2018

Right, 2FA with hardware security keys doesn't work.

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 8, 2018

This appears to be an issue with Electron apps in general and we would need this issue to be fixed for this to work: electron/electron#3226

Edited main issue to say 'U2F' instead of '2FA' as it is more specifically broken only on U2F authentication.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Jul 9, 2019

The code for this is done in cypress-io/cypress#3616, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Jul 9, 2019

Released in 3.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants