Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress.dom.isJquery is inconsistent in return #14278

Closed
bahmutov opened this issue Dec 22, 2020 · 3 comments · Fixed by #14325
Closed

Cypress.dom.isJquery is inconsistent in return #14278

bahmutov opened this issue Dec 22, 2020 · 3 comments · Fixed by #14325
Labels
pkg/driver This is due to an issue in the packages/driver directory type: bug

Comments

@bahmutov
Copy link
Contributor

Cypress v6.2.0

Cypress.dom.isJquery returns undefined instead of a boolean false

describe('page', () => {
  it('works', () => {
    cy.visit('https://example.cypress.io')
    cy.contains('Kitchen Sink').then($el => {
      console.log('is element', Cypress.dom.isElement($el))
      console.log('is jquery', Cypress.dom.isJquery($el))

      console.log('[0] is element', Cypress.dom.isElement($el[0]))
      console.log('[0] is jquery', Cypress.dom.isJquery($el[0]))

      console.log('undefined is element', Cypress.dom.isElement())
      console.log('undefined is jquery', Cypress.dom.isJquery())
    })
  })
})

Screen Shot 2020-12-22 at 2 10 55 PM

Minor, but this method should return false or true

@bahmutov
Copy link
Contributor Author

@jennifer-shehane jennifer-shehane added type: bug pkg/driver This is due to an issue in the packages/driver directory labels Dec 23, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Dec 23, 2020
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Dec 28, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 29, 2020

The code for this is done in cypress-io/cypress#14325, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 29, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 4, 2021

Released in 6.2.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.2.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/driver This is due to an issue in the packages/driver directory type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants