Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting watchForFileChanges to false keeps the Studio open #14744

Closed
filiphric opened this issue Jan 26, 2021 · 4 comments · Fixed by #14785
Closed

Setting watchForFileChanges to false keeps the Studio open #14744

filiphric opened this issue Jan 26, 2021 · 4 comments · Fixed by #14785
Assignees
Labels
experiment: studio Issues when using experimentalStudio type: bug

Comments

@filiphric
Copy link

Current behavior

Steps to replicate:

  1. set watchForFileChanges to false in cypress.json
  2. open a test and start a studio
  3. interact with your app and click on "save commands"
  4. nothing happens, studio remains open, however, scneario is added to my test file - multiple times if I click the button multiple times. which I do, because it feels unresponsive 🙈

Desired behavior

When the watchForFileChanges is set to true, clicking on „save commands“ will close the studio. I believe this would be better UX for this case as well

Test code to reproduce

I explored this in my stream, you can see the behavior at 16:20

Versions

Cypress 6.3.1

@jennifer-shehane jennifer-shehane added experiment: studio Issues when using experimentalStudio type: bug labels Jan 27, 2021
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 27, 2021
@jennifer-shehane
Copy link
Member

Love finding bugs in a live demo. 😅 Thanks for helping track down the cause. I can recreate this.

@filiphric
Copy link
Author

yeah, that will keep you alert 😆

@panzarino panzarino self-assigned this Jan 27, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jan 28, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

The code for this is done in cypress-io/cypress#14785, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Feb 1, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experiment: studio Issues when using experimentalStudio type: bug
Projects
None yet
3 participants