Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log: boolean option to cy.tick #15180

Closed
emilgoldsmith opened this issue Feb 22, 2021 · 7 comments · Fixed by #15586
Closed

Add log: boolean option to cy.tick #15180

emilgoldsmith opened this issue Feb 22, 2021 · 7 comments · Fixed by #15586
Labels
good first issue Good for newcomers type: enhancement Requested enhancement of existing feature

Comments

@emilgoldsmith
Copy link
Contributor

What would you like?

cy.tick(2000, { log: false });

Currently there is no log option on tick, as I had expected while working on customizing my log. Was wondering if it was an oversight or on purpose?

Why is this needed?

To align with the feature set surrounding allowing you to customize your log, most commands support this option so I was expecting this one to have it too, and would be nice to silence this one in a specific custom command I'm building though I'll of course live without it

@jennifer-shehane
Copy link
Member

I don't see any reason why `cy.tick()`` wouldn't allow an options argument. Probably just an oversight.
We'd be open to a PR to implement this. Check out our contributing doc.

@jennifer-shehane jennifer-shehane added stage: ready for work The issue is reproducible and in scope type: enhancement Requested enhancement of existing feature good first issue Good for newcomers labels Feb 23, 2021
@emilgoldsmith
Copy link
Contributor Author

Awesome! I’ll try getting on that in the near future :)

@saturninoabril
Copy link
Contributor

@emilgoldsmith I hope you don't mind but I went ahead and created a PR to address your issue. Let me know if that works for you.

@emilgoldsmith
Copy link
Contributor Author

emilgoldsmith commented Mar 19, 2021 via email

@nbgooch
Copy link

nbgooch commented Mar 21, 2021

Woops, looks like I created a duplicate pr.. Can close..

@jennifer-shehane
Copy link
Member

The code for this is done in #15586, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers type: enhancement Requested enhancement of existing feature
Projects
None yet
5 participants