Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix actionability when element has scroll-behavior: smooth #15453

Merged
merged 2 commits into from Mar 15, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Mar 12, 2021

User facing changelog

  • Interacting with an element that requires scrolling within an element with scroll-behavior: smooth no longer fails Cypress's actionability check

Additional details

The solution involves setting all scroll-behavior to inherit before scrolling and then resetting it after scrolling by injecting a style tag and then removing it.

How has the user experience changed?

Commands that require actionability (e.g. click) no longer fail to find the element when it's within another element with scroll-behavior: smooth.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 12, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 12, 2021



Test summary

184 0 5 0


Run details

Project cypress
Status Passed
Commit d3fc4c6
Started Mar 12, 2021 3:40 PM
Ended Mar 12, 2021 3:48 PM
Duration 08:21 💡
OS Linux Debian - 10.5
Browser Chrome 83

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2021

Released in 6.7.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.7.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2021
@chrisbreiding chrisbreiding deleted the TR-88-scroll-behavior-actionability-fix branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS scroll-behavior: smooth; on the html el breaks actionability
2 participants