Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress crashes with misleading error message "Unknown signal: true" #15943

Closed
flotwig opened this issue Apr 12, 2021 · 2 comments · Fixed by #15944
Closed

Cypress crashes with misleading error message "Unknown signal: true" #15943

flotwig opened this issue Apr 12, 2021 · 2 comments · Fixed by #15944
Labels
type: bug v7.0.0 🐛 Issue present since 7.0.0

Comments

@flotwig
Copy link
Contributor

flotwig commented Apr 12, 2021 •
edited

Current behavior

If Cypress crashes with 7.x, it will print out an "Unknown signal: true" error below the actual error due to #15751

Uncaught TypeError [ERR_UNKNOWN_SIGNAL]: Unknown signal: true

Desired behavior

When Cypress crashes, it only prints the actual crash message

Versions

7.0.0+
@flotwig flotwig added type: bug v7.0.0 🐛 Issue present since 7.0.0 labels Apr 12, 2021
@flotwig flotwig mentioned this issue Apr 12, 2021
Merged
2 tasks
@cypress-bot cypress-bot bot added the stage: work in progress There is an open PR for this issue [WIP] label Apr 12, 2021
@cypress-bot cypress-bot bot added the stage: pending release There is a closed PR for this issue label Apr 12, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

The code for this is done in cypress-io/cypress#15944, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: work in progress There is an open PR for this issue [WIP] label Apr 12, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Released in 7.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.1.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Apr 12, 2021
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug v7.0.0 🐛 Issue present since 7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't pass invalid signal to subprocess.exit on crash cypress-io/cypress
1 participant
@flotwig