Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdp startScreencast is sent when video:false #16030

Closed
kuceb opened this issue Apr 16, 2021 · 2 comments · Fixed by #15985
Closed

cdp startScreencast is sent when video:false #16030

kuceb opened this issue Apr 16, 2021 · 2 comments · Fixed by #15985
Labels
v6.7.0 🐛 Issue present since 6.7.0

Comments

@kuceb
Copy link
Contributor

kuceb commented Apr 16, 2021

Looking at the debug logs, cypress is receiving video frames from cdp browsers with video disabled, Which may impact performance
We shouldnt send startScreencast if we're not recording video
Introduced in 7.0.0

@kuceb kuceb changed the title cdp startScreencast is sent even when video:false cdp startScreencast is sent when video:false Apr 16, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 16, 2021

The code for this is done in cypress-io/cypress#15985, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane jennifer-shehane added the v7.0.0 🐛 Issue present since 7.0.0 label Apr 26, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2021
@jennifer-shehane jennifer-shehane added v6.7.0 🐛 Issue present since 6.7.0 and removed v7.0.0 🐛 Issue present since 7.0.0 labels Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v6.7.0 🐛 Issue present since 6.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants