Cypress adds `should` to every object?

[juanmendes]

I use cypress with the cucumber plugin and noticed that the following TypeScript code which compiles without a problem but crashes at runtime.

const a = 1;
a.should("be.visible");

This is because the following which is downloaded when I npm i cypress: node_modules/cypress/types/chai/index.d.ts:1943

interface Object {
    should: Chai.Assertion;
}

This is causing TypeScript to give me false positives everywhere because I called should() on something that is not a Cypress Chainable but I don't find out about it until runtime.

Augmenting Object's TypeScript definition with an extra method seems like something we did away with since prototype JS taught us how bad it was. Why is it being done? Should I file a bug? It really stinks to have to run a file to be told I have what should be compilation errors.

Originally posted by @juanmendes in #16526

[jennifer-shehane]

@juanmendes We'll review a PR to fix any type bugs if you'd like to submit one.

[juanmendes]

@juanmendes We'll review a PR to fix any type bugs if you'd like to submit one.

I can work on this if there's some direction on what to do, so I can avoid working down a rabbit hole

[cypress-bot]

The code for this is done in cypress-io/cypress#16744, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 7.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.5.0, please open a new issue.