Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"duplicate length frame received" debug logs in chrome, should only apply to firefox webm recording #16648

Closed
kuceb opened this issue May 24, 2021 · 2 comments · Fixed by #16649

Comments

@kuceb
Copy link
Contributor

kuceb commented May 24, 2021

For longer chrome/electron tests, users are seeing debug logs cluttered with 'duplicate length frame received'. This logic for duplicate video frames was implemented as part of firefox support and should not apply to chrome/electron.

current behavior:
'duplicate length frame received' is sometimes shown in debug logs for browsers other than firefox

desired behavior:
no 'duplicate length frame received' logs should occur outside of firefox testing

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels May 24, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 24, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 24, 2021

The code for this is done in cypress-io/cypress#16649, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 24, 2021

Released in 7.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants