Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default screen size for headless runs to be 1280x720 #16853

Closed
jennifer-shehane opened this issue Jun 8, 2021 · 2 comments
Closed

Make default screen size for headless runs to be 1280x720 #16853

jennifer-shehane opened this issue Jun 8, 2021 · 2 comments
Assignees
Labels
topic: video 📹 type: breaking change Requires a new major release version

Comments

@jennifer-shehane
Copy link
Member

What would you like?

The default screen size for headless runs in Cypress should be 1280x720.

Why is this needed?

In an attempt to improve the resolution of screenshots and videos, we updated the resolution of videos to be 1920x1080 in Cypress 7.0: #15686

After running many tests in different OS's, containers, screen sizes, hiDPI, etc, we've concluded that this previous change did not improve the resolution of videos. In fact, it made the videos and screenshots less readable as the content is now tiny.

Making the breaking change to set the size back to 1280x720 is part of a larger part of stories to improve default video and screenshot resolution. See #16832

Before 7.0 (1280x720)

cypress-video167c6393-adbe-4d06-b535-08396ba4035c.mp4

After 7.0 (1920x720)

cypress-video91e04f08-aa84-49e4-81d6-0e21ccca4f64.mp4
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2021

The code for this is done in cypress-io/cypress#17309, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2021

Released in 8.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: video 📹 type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants