Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox beforeinput event support #17583

Closed
btjones opened this issue Aug 3, 2021 · 5 comments · Fixed by #17820
Closed

Firefox beforeinput event support #17583

btjones opened this issue Aug 3, 2021 · 5 comments · Fixed by #17820

Comments

@btjones
Copy link
Contributor

btjones commented Aug 3, 2021

What would you like?

I would love to get beforeinput support in Firefox now that Firefox supports it.

Why is this needed?

This would be beneficial to anyone relying on the Firefox beforeinput event - otherwise that functionality cannot be tested with Cypress. In my case I am building a text editor which relies heavily on this event.

Other

beforeinput support was added to Cypress last year for Chromium browsers. Firefox has also added support for the beforeinput event which was added in version 87.

In this PR where beforeinput support was added there is a check specifically for the Chromium family of browsers. It would be great if Cypress triggered this event for Firefox (87+) just as it does for Chromium browsers.

@btjones
Copy link
Contributor Author

btjones commented Aug 19, 2021

Looks like this is starting to get buried a few pages deep - wondering if anyone from the cypress team could comment on if this either already is or could be added to the roadmap? Thanks!

@JessicaSachs
Copy link
Contributor

It's not on the roadmap right now and may take us a little bit to get to. Our Firefox userbase is actually quite small, so in order to get the fix in soon, you should consider submitting a PR.

@btjones
Copy link
Contributor Author

btjones commented Aug 20, 2021

@JessicaSachs here's a PR (plus draft documentation PR):

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Aug 23, 2021
@btjones
Copy link
Contributor Author

btjones commented Aug 24, 2021

@JessicaSachs Thanks for getting the proper people assigned to review my PR (which has been merged) 🎉 I've converted the associated documentation PR from a draft to ready for review but noticed there are no automatic assignees. Is there anything else I need to do to get a review on that? Thanks!

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2021

Released in 8.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.3.1, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Aug 27, 2021
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants