Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types for clientCertificate #17799

Closed
lmiller1990 opened this issue Aug 19, 2021 · 9 comments · Fixed by #18028
Closed

Missing types for clientCertificate #17799

lmiller1990 opened this issue Aug 19, 2021 · 9 comments · Fixed by #18028
Labels
good first issue Good for newcomers stage: needs review The PR code is done & tested, needs review type: typings Issue related to Cypress types (for TypeScript)

Comments

@lmiller1990
Copy link
Contributor

lmiller1990 commented Aug 19, 2021

Current behavior

There is a clientCertificates option. https://docs.cypress.io/guides/references/client-certificates#Syntax

It should include in the type definitions: https://github.com/cypress-io/cypress/blob/develop/cli/types/cypress.d.ts#L2491

Desired behavior

Included in types.

Test code to reproduce

const C: Cypress.ResolvedConfigOptions = {
  clientCertificates: // <- no completion or hint
}

Cypress Version

8.0.0

Other

This is a good first issue for a new contributor or a new employee. Although adding the type is simple enough, it's a good way to learn how to set up Cypress locally, make a PR, get a review, etc. Let's encourage a new contributor to take this one.

@lmiller1990 lmiller1990 added the good first issue Good for newcomers label Aug 19, 2021
@Jayita10
Copy link

I want to work on this issue

@JessicaSachs
Copy link
Contributor

I want to work on this issue

Go for it @Jayita10. Do you need anything?

@Jayita10
Copy link

Hi, I'm not able to understand the type definitions part, How should I proceed with this

@JessicaSachs
Copy link
Contributor

You'd need to open the file Lachlan linked and add the types for the clientCertificate field. There are examples in that file.

@Et-008
Copy link

Et-008 commented Aug 25, 2021

Hi, is this issue still open?
if yes, I'd like to work on it, thanks.

@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label Aug 25, 2021
@jennifer-shehane
Copy link
Member

@Et-008 Yes

@aashish0909
Copy link

Hey, is this issue still open?

@lmiller1990
Copy link
Contributor Author

@aashish0909 the work has been completed in #18028 so it will be closed soon and marked as done.

If you are looking for some good first issues, I can probably tag you in a few, if you like.

@aashish0909
Copy link

@lmiller1990 Yeah, please do. It will be really helpful.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stage: needs review The PR code is done & tested, needs review type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants