Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

everyNthFrame should only be applied for Chrome 89+ #18021

Closed
jennifer-shehane opened this issue Sep 8, 2021 · 1 comment · Fixed by #18392
Closed

everyNthFrame should only be applied for Chrome 89+ #18021

jennifer-shehane opened this issue Sep 8, 2021 · 1 comment · Fixed by #18392
Assignees
@davidmunechika
Labels
browser: chrome topic: video 📹 type: regression A bug that didn't appear until a specific Cy version release v8.3.0 🐛 Issue present since 8.3.0

Comments

@jennifer-shehane
Copy link
Member

Current behavior

In this PR #17408, we introduced capturing everyNthFrame to reduce the number of frames captured since Chrome began capturing more frames in Chrome 89+ (to help with performance). But the fix was applied broadly across all Chrome versions so that when running Cypress in Chrome 87, for example, the video will have a lot less frames and look choppy.

Desired behavior

No response

Test code to reproduce

  • cypress run with video recording on in Chrome 88 or below.

Cypress Version

8.3.1

Other

No response
@jennifer-shehane jennifer-shehane added browser: chrome type: regression A bug that didn't appear until a specific Cy version release topic: video 📹 v8.3.0 🐛 Issue present since 8.3.0 labels Sep 8, 2021
@davidmunechika davidmunechika mentioned this issue Oct 7, 2021
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 7, 2021
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 11, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2021

Released in 8.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidmunechika davidmunechika

Labels
browser: chrome topic: video 📹 type: regression A bug that didn't appear until a specific Cy version release v8.3.0 🐛 Issue present since 8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: everyNthFrame should only be applied for Chrome 89+ cypress-io/cypress
2 participants
@jennifer-shehane @davidmunechika