Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remoteOirgin should point to DRONE_GIT_SSH_URL for drone CI ENV VARS #18210

Closed
lifeiscontent opened this issue Sep 22, 2021 · 2 comments · Fixed by #18222
Closed

remoteOirgin should point to DRONE_GIT_SSH_URL for drone CI ENV VARS #18210

lifeiscontent opened this issue Sep 22, 2021 · 2 comments · Fixed by #18222

Comments

@lifeiscontent
Copy link

Current behavior

cypress/packages/server/lib/util/ci_provider.js

Line 508 in f82c08e

// remoteOrigin: ???

Desired behavior

DRONE_GIT_SSH_URL should be used for remoteOrigin

Test code to reproduce

N/A

Cypress Version

ALL

Other

No response
@jennifer-shehane jennifer-shehane mentioned this issue Sep 23, 2021
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] and removed stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] labels Sep 23, 2021
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Sep 27, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 27, 2021

The code for this is done in cypress-io/cypress#18222, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 27, 2021

Released in 8.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.5.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Sep 27, 2021
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add drone env for the url of the repo cypress-io/cypress
1 participant
@lifeiscontent