Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for cy.request options says conflicting things #18271

Closed
gustawx opened this issue Sep 28, 2021 · 3 comments · Fixed by #18316
Closed

Error message for cy.request options says conflicting things #18271

gustawx opened this issue Sep 28, 2021 · 3 comments · Fixed by #18316
Assignees

Comments

@gustawx
Copy link

gustawx commented Sep 28, 2021

Current behavior

Mistake in error message when setting retryOnStatusCodeFailure: true and failOnStatusCode = false in cy.request

image

Desired behavior

correct error message

Test code to reproduce

cy.request({
    url: someUrl,
    retryOnStatusCodeFailure: true,
    failOnStatusCode = false
  })

Cypress Version

8.4.1

Other

No response

@jennifer-shehane
Copy link
Member

Yeah this does not make sense. Thanks for pointing this out.

@jennifer-shehane jennifer-shehane changed the title Wrong error message Error message for cy.request options says conflicting things Sep 28, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: to do labels Sep 30, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 1, 2021

The code for this is done in cypress-io/cypress#18316, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 1, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2021

Released in 8.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants