Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have default nodeVersion be set to system instead of bundled #18684

Closed
jennifer-shehane opened this issue Oct 28, 2021 · 4 comments
Closed

Have default nodeVersion be set to system instead of bundled #18684

jennifer-shehane opened this issue Oct 28, 2021 · 4 comments
Assignees
@mjhenkes
Labels
type: breaking change Requires a new major release version

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Oct 28, 2021 •
edited
Loading

What would you like?

The default nodeVersion currently for Cypress is set to bundled. This means that the bundled Node.js version with Cypress will be used to:

  • Build files in the cypress/integration folder.
  • Build files in the cypress/support folder.
  • Execute code in the cypress/plugins file.

We'd like the default nodeVersion to be set to system in the future.
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Oct 28, 2021
@brian-mann
Copy link
Member

we need to lift off process.execPath from the CLI and pass that to the binary as a flag, so the user does not need to tell us anything.

this is different from the current implementation of how system works today since it wouldn't ever need to "find" the node version, but rather always use the one that's invoking the CLI.

@ZachJW34 ZachJW34 mentioned this issue Oct 28, 2021
Merged
5 tasks
@jennifer-shehane jennifer-shehane mentioned this issue Oct 28, 2021
Merged
7 tasks
@mjhenkes mjhenkes self-assigned this Oct 29, 2021
@mjhenkes mjhenkes mentioned this issue Nov 1, 2021
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Nov 1, 2021
@mjhenkes mjhenkes mentioned this issue Nov 2, 2021
Merged
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 4, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 4, 2021

The code for this is done in cypress-io/cypress#18732, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@mjhenkes mjhenkes mentioned this issue Nov 4, 2021
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: pending release stage: needs review The PR code is done & tested, needs review labels Nov 4, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2021

The code for this is done in cypress-io/cypress#18796, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Nov 5, 2021
@mjhenkes mjhenkes closed this as completed Nov 5, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2021

Released in 9.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjhenkes mjhenkes

Labels
type: breaking change Requires a new major release version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brian-mann @jennifer-shehane @mjhenkes