Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expecting element to be disabled results in maximum call stack size error #1958

Closed
MichaelHindley opened this issue Jun 15, 2018 · 6 comments

Comments

3 participants
@MichaelHindley
Copy link

commented Jun 15, 2018

Current behavior:

When expecting something to not be disabled(or quite possibly when expecting on jqueryfied objects, or other assertions), the error field is set to Maximum call stack size exceeded

Test repo

Desired behavior:

It should show the failed assertion with a nice human readable error.

Steps to reproduce:

git clone git@github.com:MichaelHindley/cypress-stack-test.git
cd cypress-stack-test
yarn && yarn dev
visit localhost:3001

image

Versions

3.0.1

@jennifer-shehane

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

I'm not experiencing this with the tests you have posted in your repo.

screen shot 2018-06-15 at 12 23 33 pm

We also generally do not recommend testing sites outside of your control for a variety of reasons

@MichaelHindley

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

are you looking at the JSON returned by cypress.run()?

I've added a Docker runnable example that runs on node 8 jessie, the same error is present there.

image

@MichaelHindley

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

So I've added a Docker runnable example in the test repo to ensure that same environment can be used to debug, and a case where it runs against a local index.html that has just an button.

I haven't been able to figure out a common denominator though, in a bare-bones index.html, everything works as expected, but it seems that both we internally in our apps and google.com do something in the DOM that makes Cypress error out with call stack limit when a expectation fails it's check.

image

@flotwig

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

I was able to reproduce the call stack error, adding #4407 seems to fix it and allow the test to run as expected:

image

@cypress-bot

This comment has been minimized.

Copy link

commented Jun 13, 2019

The code for this is done in cypress-io/cypress#4407, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

commented Jun 27, 2019

Released in 3.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.